Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everest-framework for Rust #639

Merged

Conversation

dorezyuk
Copy link
Contributor

Update the everest-framework for Rust

Signed-off-by: Dima Dorezyuk <[email protected]>
@dorezyuk dorezyuk force-pushed the feat/update_everest_framework_upstream branch from 2011397 to f58aadf Compare April 18, 2024 06:36
Copy link
Contributor

@SirVer SirVer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SirVer
Copy link
Contributor

SirVer commented Apr 18, 2024

why does this require somebody else but us to review? It only touches Rust + Bazel stuff? @hikinggrass do you know?

@Pietfried
Copy link
Contributor

why does this require somebody else but us to review? It only touches Rust + Bazel stuff? @hikinggrass do you know?

I think thats because of the .cargo and .lock files that have changed. Feel free to open a PR to add more specifications for the rust context.

Copy link
Contributor

@golovasteek golovasteek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dorezyuk dorezyuk merged commit 428758a into EVerest:main Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants