Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation of Auth module #683

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented May 13, 2024

Describe your changes

Updated documentation of Auth module:

  • Moved README.md to index.rst
  • Value FindFirst was added as a value for the selection_algorithm and was missing a proper description
  • Added description for selection_algorithm in manfiest.yaml

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Contributor

@krealyt krealyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pietfried
Copy link
Contributor Author

@corneliusclaussen your approval is required for this one

@corneliusclaussen corneliusclaussen force-pushed the docs/update-auth-module branch from 09b1c7c to 5c1fcd5 Compare May 23, 2024 08:36
* Moved README.md to index.rst
* Value `FindFirst` was added as a value for the `selection_algorithm` and was missing a proper description
* Added description for selection_algorithm in manfiest.yaml

Signed-off-by: pietfried <[email protected]>
@Pietfried Pietfried force-pushed the docs/update-auth-module branch from 91288ff to b726c5b Compare June 3, 2024 11:02
@Pietfried Pietfried merged commit fd34de7 into main Jun 3, 2024
5 checks passed
@Pietfried Pietfried deleted the docs/update-auth-module branch June 3, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants