Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Notify Evse also when authorization is rejected #698

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented May 24, 2024

Describe your changes

Extended Auth module so that it notifies the Evse also in case a token was rejected. This is especially required to allow the ISO15118 state machine to escape the authorize loop when a Plug&Charge authorization was rejected.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@Pietfried Pietfried marked this pull request as draft May 24, 2024 20:05
@Pietfried Pietfried force-pushed the feature/auth-notify-evse-on-auth-rejected branch from f39d68b to d6ea726 Compare May 24, 2024 20:07
@Pietfried Pietfried marked this pull request as ready for review May 30, 2024 15:16
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Pietfried and others added 3 commits June 11, 2024 08:55
…n was rejected. This is especially required to allow the ISO15118 state machine to escape the authorize loop when a Plug&Charge authorization was rejected

Signed-off-by: pietfried <[email protected]>
@corneliusclaussen corneliusclaussen force-pushed the feature/auth-notify-evse-on-auth-rejected branch from 1dd7331 to c0c8ab6 Compare June 11, 2024 06:55
@Pietfried Pietfried merged commit 648b38d into main Jun 11, 2024
6 checks passed
@Pietfried Pietfried deleted the feature/auth-notify-evse-on-auth-rejected branch June 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants