Fixing empty string in EvseSecurity config #708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checking if private key password is empty and passing std::nullopt to EvseSecurity ctor in this case.
This change is required, because even if the config parameter
private_key_password
is not configured, the constructor will pass an empty string instead of std::nullopt. This will cause private keys to be encrypted every time.Issue ticket number and link
Checklist before requesting a review