feat: use hex digits for SSID #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-ctc
requested review from
hikinggrass,
corneliusclaussen and
Pietfried
as code owners
james-ctc
force-pushed
the
fix/wi-fi-ssid-support-for-non-ascii
branch
2 times, most recently
from
bf9019b to
451e25e
Compare
hikinggrass
requested changes
Jul 30, 2024
feat: added SSID string to hex and back functions Signed-off-by: James Chapman <[email protected]>
Signed-off-by: James Chapman <[email protected]>
Signed-off-by: James Chapman <[email protected]>
james-ctc
force-pushed
the
fix/wi-fi-ssid-support-for-non-ascii
branch
from
451e25e to
00babdf
Compare
hikinggrass
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added SSID string to hex and back functions
Describe your changes
Over the everest-api you can request a list of visible wifi networks and then connect.
SSIDs can contain non-printable characters (as well as ASCII/UTF-8) these are escaped (\xnn) in the SSID list.
The problem was that when attempting to connect the escaped characters were not being accepted.
The solution is to pass the SSID to wpa_supplicant as a string of hex digits.
Issue ticket number and link
Addresses the underlying issue in Issue #760
with a slightly different solution
Checklist before requesting a review