OCPP201: Add trigger_reason argument #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…updated. Moved conversion from stop_reason to trigger_reason from libocpp to OCPP201 module Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
feature/add-trigger-reason-to-transaction-finished
branch
from
9f834d5 to
707ecc5
Compare
Pietfried
requested review from
hikinggrass,
maaikez and
corneliusclaussen
as code owners
Pietfried
commented
Jul 23, 2024
Signed-off-by: Piet Gömpel <[email protected]>
hikinggrass
approved these changes
Jul 23, 2024
maaikez
reviewed
Jul 23, 2024
| @@ -864,6 +915,15 @@ void OCPP201::process_transaction_finished(const int32_t evse_id, const int32_t | |||
| this->charge_point->on_charging_state_changed(evse_id, ocpp::v201::ChargingStateEnum::EVConnected, | |||
| ocpp::v201::TriggerReasonEnum::StopAuthorized); | |||
| } | |||
| } else { | |||
| // TODO(piet): If StopTxOnEVSideDisconnect is false, authorization shall still be present. This cannot only be | |||
There was a problem hiding this comment.
yes, cant be handled here and requires change to EvseManager and Auth
maaikez
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added trigger_reason to on_transaction_finished since libocpp API is updated. Moved conversion from stop_reason to trigger_reason from libocpp to OCPP201 module
Issue ticket number and link
Companion PR in libocpp: EVerest/libocpp#698
Checklist before requesting a review