DC Power supply: Add charging phase information #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
Pietfried,
hikinggrass and
james-ctc
as code owners
3 tasks
hikinggrass
approved these changes
Jul 30, 2024
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
feature/dc_powersupply_chargingphase
branch
from
f41b56d to
dedb9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In some special setups, the DC power supply needs to know if it is switched on for cable check, pre charge or actual charging phase as it may handle that differently internally. Most PSUs should not need to know as they should always operate in CCCV mode independent of the phase.
This PR adds the charging phase information to the setMode command.
It also drops the JsDCSupplySimulator module as it is not used anymore.
Issue ticket number and link
Checklist before requesting a review