feature(ocpp): transmit error message instead of description #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously the transmitted error info inside OCPPs StatusNotification message contained the error description of a `VendorError`, that was raised within everest -- now it contains the error message - this should be more appropriate, as the error description is fixed (static), whereas the message can be specified at runtime - note, that the difference between an error description and an error message is definitely not self-explanatory and probably lead to this behaviour (this should be fixed in the error api) - when using this, keep in mind, that OCPPs `info` property within the StatusNotification message can only contain up to 50 characters -- if the error message is longer, it will get truncated Signed-off-by: aw <[email protected]>
a-w50
requested review from
hikinggrass,
Pietfried and
maaikez
as code owners
Signed-off-by: aw <[email protected]>
Pietfried
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
VendorError, that was raised within everest -- now it contains the error messageinfoproperty within the StatusNotification message can only contain up to 50 characters -- if the error message is longer, it will get truncatedIssue ticket number and link
Checklist before requesting a review