fix: TLS server certificate_sha_1 calculated incorrect hash #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certificate_sha_1() was originally used to calculate a unique value representing a certificate. For trusted_ca_keys the certificate hash needs to be over the whole certificate. certificate_sha_1() updated to calculate the correct hash. unit tests added to check the calculated hash python test script to print trusted_ca_keys and certificate hashes Signed-off-by: James Chapman <[email protected]>
james-ctc
requested review from
AssemblyJohn,
corneliusclaussen and
SebaLukas
as code owners
AssemblyJohn
approved these changes
Oct 9, 2024
The hash is calculated of the full DER encoding of the certificate. |
hikinggrass
pushed a commit
that referenced
this pull request
Oct 14, 2024
certificate_sha_1() was originally used to calculate a unique value representing a certificate. For trusted_ca_keys the certificate hash needs to be over the whole certificate. certificate_sha_1() updated to calculate the correct hash. unit tests added to check the calculated hash python test script to print trusted_ca_keys and certificate hashes Signed-off-by: James Chapman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
certificate_sha_1() was originally used to calculate a unique value representing a certificate. For trusted_ca_keys the certificate hash needs to be over the whole certificate.
certificate_sha_1() updated to calculate the correct hash. unit tests added to check the calculated hash
python test script to print trusted_ca_keys and certificate hashes
Issue ticket number and link
Checklist before requesting a review