Use min/max phase on leaf side #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
Pietfried and
hikinggrass
as code owners
corneliusclaussen
force-pushed
the
bugfix/use-min-max-phase-leave-side
branch
from
2105c1b to
d7b99e7
Compare
|
Nit: "leave" -> "leaf"? |
Pietfried
approved these changes
Oct 30, 2024
hikinggrass
changed the title
corneliusclaussen
force-pushed
the
bugfix/use-min-max-phase-leave-side
branch
from
d7b99e7 to
17303e7
Compare
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
bugfix/use-min-max-phase-leave-side
branch
from
17303e7 to
d71ad19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
number of phase limits are now also used on the leave side of an energy limit object
Issue ticket number and link
Checklist before requesting a review