-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote start stop #110
Merged
Merged
Remote start stop #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17823d5
to
4fcc6bf
Compare
Pietfried
requested changes
Jul 6, 2023
f0fbd00
to
ccb560a
Compare
6fa5a3d
to
2f1b360
Compare
Pietfried
approved these changes
Jul 12, 2023
2f1b360
to
81f54e8
Compare
Signed-off-by: Maaike Zijderveld, Alfen <[email protected]> Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
…on. Implement more functional requirements. Implement remote stop transaction request. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
… is not covered because of TxStartPoint PowerPathClosed is the only one that is currently available. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]> Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
Signed-off-by: Maaike Zijderveld, Alfen <[email protected]> Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
…on with remote start / stop transaction. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]> Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
…hange connector to loop over connectors from id 1 instead of 0. is_evse_connector_available removes occupied check. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
…callback and use stop_transaction_callback. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
…allback. Change CallResult to Call for incoming requests. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
…ent token. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
…t parameter Signed-off-by: pietfried <[email protected]> Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
Signed-off-by: pietfried <[email protected]> Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented remote start / stop. There are some todo's left which have a major impact on the code (for example checking the charging profile). Not tested yet.