Transaction event changes to get remote start / stop working and compliant to octt #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
approved these changes
Aug 16, 2023
maaikez
force-pushed
the
mz-transaction-event
branch
2 times, most recently
from
f0699b7 to
e929756
Compare
…mote start id and send trigger reason RemoteStart with the very first transaction event after the remote start request. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
Signed-off-by: Maaike <[email protected]> Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
Signed-off-by: Maaike <[email protected]> Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
…onEventEnum::Started Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
bWF0dGhpYXMK
pushed a commit
to bWF0dGhpYXMK/libocpp
that referenced
this pull request
Sep 27, 2023
…liant to octt (EVerest#138) * Send a transaction event after every charging state changed. Store remote start id and send trigger reason RemoteStart with the very first transaction event after the remote start request. * Also add charging state to newly created transaction * Add charging state to on_transaction_stopped * Move remote start triggerreason up so it is also sent for a TransactionEventEnum::Started Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.