Split off SQLite statement wrapper into own file and apply to v201 usages #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Emmers <[email protected]>
…ter in the statement Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Pietfried
approved these changes
Aug 23, 2023
bWF0dGhpYXMK
pushed a commit
to bWF0dGhpYXMK/libocpp
that referenced
this pull request
Sep 27, 2023
…ages (EVerest#149) * Split off the sqlite statement class to its own header Signed-off-by: Marc Emmers <[email protected]> * Swap bind argument order and add overloads that can search the parameter in the statement Signed-off-by: Marc Emmers <[email protected]> * Update v201 database handler using the sql statement wrapper Signed-off-by: Marc Emmers <[email protected]> * Add string lifetime to sqlite statement bind functions Signed-off-by: Marc Emmers <[email protected]> * Fix storage duration of text bindings in device model Signed-off-by: Marc Emmers <[email protected]> * Apply format to sqlite_statement.hpp Signed-off-by: Marc Emmers <[email protected]> * Fix format Signed-off-by: Marc Emmers <[email protected]> --------- Signed-off-by: Marc Emmers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with the ocpp201 tests currently available without regression. 6 test cases do fail, they also fail with current main.