Make it possible to use own logger instead of everest logger. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
force-pushed
the
mz-enable-external-logging
branch
from
396ee7c to
78e1f7f
Compare
Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
marcemmers
reviewed
Aug 23, 2023
| @@ -7,6 +7,8 @@ | |||
| #include <ocpp/common/pki_handler.hpp> | |||
| #include <ocpp/common/websocket/websocket.hpp> | |||
|
|
|||
| #include <boost/shared_ptr.hpp> | |||
There was a problem hiding this comment.
Why is the boost shared_ptr still used?
There was a problem hiding this comment.
Because otherwise libocpp does fail to build if we use our own logging.
Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
hikinggrass
approved these changes
Aug 24, 2023
bWF0dGhpYXMK
pushed a commit
to bWF0dGhpYXMK/libocpp
that referenced
this pull request
Sep 27, 2023
…t#150) * Make it possible to use own logger instead of everest logger. Signed-off-by: Maaike Zijderveld, Alfen <[email protected]> * formatting Signed-off-by: Maaike Zijderveld, Alfen <[email protected]> --------- Signed-off-by: Maaike Zijderveld, Alfen <[email protected]> Co-authored-by: Patrick van Bennekom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.