Add local authorization list management calls (D01 and D02) #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was actually pondering if I should hash the token_id and token_id_type here as well but the ocpp spec does not have a recommendation for it for the local auth list. Any opinions here? Edit: Spoke to Robert about this and we thought it best to use the hash here too. The only downside we could think of was the size a token takes in the database. I think the hash will be a minor proportion of a token in the local list as it is but we want to we could improve it a bit by storing the hash as base32 or a raw blob. |
Pietfried
requested changes
Aug 28, 2023
Signed-off-by: Maaike Zijderveld, Alfen <[email protected]> Remove comments, already taken care of in other branch Signed-off-by: Marc Emmers <[email protected]> Update local list database; uses both token and type as primary key, store token_info as json string Signed-off-by: Marc Emmers <[email protected]> Updated local list functions using new sqlite wrapper Signed-off-by: Marc Emmers <[email protected]> Add database function to get number of entries Signed-off-by: Marc Emmers <[email protected]> Add local list functions (wip) Signed-off-by: Marc Emmers <[email protected]> Update config with actual values Signed-off-by: Marc Emmers <[email protected]> Fix enabled check and writing the number of entries Signed-off-by: Marc Emmers <[email protected]> Add missing status for differential update Signed-off-by: Marc Emmers <[email protected]> Consistent naming of local authorization list functions Signed-off-by: Marc Emmers <[email protected]> Fix style Signed-off-by: Marc Emmers <[email protected]> Use hash for storing local list items too. Fix SQL style issue in init_core.sql Signed-off-by: Marc Emmers <[email protected]> Move function to appropriate location and use the request directly without the call wrapper Signed-off-by: Marc Emmers <[email protected]>
marcemmers
force-pushed
the
mz-authlist
branch
from
6641073 to
fcd22b1
Compare
Pietfried
approved these changes
Sep 6, 2023
bWF0dGhpYXMK
pushed a commit
to bWF0dGhpYXMK/libocpp
that referenced
this pull request
Sep 27, 2023
Remove comments, already taken care of in other branch Update local list database; uses both token and type as primary key, store token_info as json string Updated local list functions using new sqlite wrapper Add database function to get number of entries Add local list functions (wip) Update config with actual values Fix enabled check and writing the number of entries Add missing status for differential update Consistent naming of local authorization list functions Fix style Use hash for storing local list items too. Fix SQL style issue in init_core.sql Move function to appropriate location and use the request directly without the call wrapper Signed-off-by: Marc Emmers <[email protected]> Co-authored-by: Maaike Zijderveld, Alfen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.