Refactored pki_handler to evse_security #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pietfried
commented
Aug 31, 2023
Pietfried
commented
- removed pki handler impl and header from libocpp and replaced by evse_security.hpp, which can be provided externally from libocpp consumer.
- Refactored all parts where pki_handler was used with usage of evse_security
- added dependency to libevse-security and used this for implementation of evse_security interface. This internal evse_security_impl is used if no external implementation is given in the ChargePoint constructor
marcemmers
reviewed
Aug 31, 2023
| /// \param certificate_type specifies the CA certificate type | ||
| /// \return result of the operation | ||
| virtual InstallCertificateResult install_ca_certificate(const std::string& certificate, | ||
| const CaCertificateType& certificate_type) = 0; |
There was a problem hiding this comment.
I was wondering this in our call earlier today too. Why are we passing enum class arguments by const reference? Seems like by value would be simpler and more code efficient as well.
There was a problem hiding this comment.
this is just a matter of habbit, they could also be passed by value. In general, there are a couple of things we could target for a larger styling refactor of libocpp, which is already on our list :)
Pietfried
force-pushed
the
pg-pki-handler-to-evse-security
branch
2 times, most recently
from
563697c to
e8983aa
Compare
Pietfried
force-pushed
the
pg-pki-handler-to-evse-security
branch
from
e8983aa to
6a6c582
Compare
maaikez
reviewed
Sep 18, 2023
lib/ocpp/v201/charge_point.cpp
Outdated
| this->device_model->get_optional_value<bool>(ControllerComponentVariables::AdditionalRootCertificateCheck) | ||
| .value_or(false)); | ||
| this->database_handler = std::make_shared<DatabaseHandler>(core_database_path, sql_init_path); | ||
| this->evse_security = evse_security; |
There was a problem hiding this comment.
Please remove this line. evse_security is already initialized in ChargingStationBase. If you set evse_security to nullptr, a new instance is created in ChargingStationBase and overwritten with this line.
Pietfried
force-pushed
the
pg-pki-handler-to-evse-security
branch
2 times, most recently
from
4b7d0b8 to
643dfe2
Compare
Pietfried
force-pushed
the
pg-pki-handler-to-evse-security
branch
from
643dfe2 to
5c2c133
Compare
hikinggrass
approved these changes
Sep 29, 2023
…_security.hpp, which can be provided externally from libocpp consumer. Refactored all parts where pki_handler was used with usage of evse_security Signed-off-by: pietfried <[email protected]>
… of evse_security interface. This internal evse_security_impl is used of no external implementation is given in the ChargePoint constructor Signed-off-by: pietfried <[email protected]>
Signed-off-by: Ioan Bogdann <[email protected]> Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]> Signed-off-by: pietfried <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]> Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
pg-pki-handler-to-evse-security
branch
from
48a9fc1 to
2530619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.