Fix handling of pending transactions in v16 at startup #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…queued; This change is required because without this check the StopTransaction.req could be sent twice for the same transaction on startup because since e865d20 the transaction message queue is also loaded on startup Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
pg-transaction-handling-on-power-loss
branch
from
757b6be to
6f62033
Compare
hikinggrass
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only stopping pending transactions if StopTransaction.req was not yet queued in a previous run.
This change is required because without this check the StopTransaction.req could be sent twice for the same transaction on startup because since e865d20 the transaction message queue is also loaded on startup.
stop_pending_transactions now only stops transaction for which not StopTransaction.req was queued (sudden PowerLoss)