Support of security profile for example charge_point #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
barsnick
reviewed
Nov 8, 2023
barsnick
reviewed
Nov 8, 2023
| @@ -100,8 +100,42 @@ int main(int argc, char* argv[]) { | |||
| fs::create_directories(cso_path); | |||
| } | |||
|
|
|||
| const fs::path csms_path = "/tmp/client/csms"; | |||
| if (!fs::exists(csms_path)) { | |||
| fs::create_directories(csms_path); | |||
There was a problem hiding this comment.
Shouldn't you explicitly include ocpp/common/support_older_cpp_versions.hpp for the fs namespace? It seems it is implicitly included via some other #include. (I don't know about EVerest's code policy on this, feel free to clarify).
There was a problem hiding this comment.
Thank you for your comments; yes, it is included over the charge_point.hpp, i have no clear opinion on that.
There was a problem hiding this comment.
implicitly included via some other #include
I'm in favour to explicitly include them. Just found the IWYU (https://include-what-you-use.org/) tool which checks this (at least it should, don't have own experience with it, yet).
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.