Support of mutex inside get/set of configuration, which can be happen… #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, when getConfiguration is called from outside, during a changeconfiguration processing Signed-off-by: Matthias Suess <[email protected]>
…me thread Signed-off-by: Matthias Suess <[email protected]>
Pietfried
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Hi, thanks for bringing this up and sorry for the the late feedback. I would rather like to avoid the recursive mutex to reduce complexity. This could be done with a small refactor of the private/public functions for setting and getting the custom configuration keys. This might be a helpful resource: https://stackoverflow.com/a/14600868
Pietfried
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, when getConfiguration is called from outside, during a changeconfiguration processing.