If no changeconfiguration callback is register call the generic one, … #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if present Signed-off-by: Matthias Suess <[email protected]>
…changeconfiguration
Pietfried
reviewed
Jan 2, 2024
lib/ocpp/v16/charge_point.cpp
Outdated
| @@ -280,6 +280,11 @@ void ChargePoint::register_configuration_key_changed_callback( | |||
| this->charge_point->register_configuration_key_changed_callback(key, callback); | |||
| } | |||
|
|
|||
| void ChargePoint::register_configuration_key_changed_callback( | |||
| const std::function<void(const CiString<50>& key, const CiString<500>& valuee)>& callback) { | |||
There was a problem hiding this comment.
Suggested change
| const std::function<void(const CiString<50>& key, const CiString<500>& valuee)>& callback) { | |
| const std::function<void(const CiString<50>& key, const CiString<500>& value)>& callback) { |
Pietfried
requested changes
Jan 2, 2024
lib/ocpp/v16/charge_point.cpp
Outdated
| @@ -280,6 +280,11 @@ void ChargePoint::register_configuration_key_changed_callback( | |||
| this->charge_point->register_configuration_key_changed_callback(key, callback); | |||
| } | |||
|
|
|||
| void ChargePoint::register_configuration_key_changed_callback( | |||
| const std::function<void(const CiString<50>& key, const CiString<500>& valuee)>& callback) { | |||
There was a problem hiding this comment.
Suggested change
| const std::function<void(const CiString<50>& key, const CiString<500>& valuee)>& callback) { | |
| const std::function<void(const CiString<50>& key, const CiString<500>& value)>& callback) { |
include/ocpp/v16/charge_point.hpp
Outdated
| /// \brief registers a \p callback function that can be used to react on changed configuration key. This | ||
| /// callback is called when a configuration key has been changed by the CSMS | ||
| /// \param callback executed when this configuration key changed | ||
| void register_configuration_key_changed_callback( |
There was a problem hiding this comment.
Suggested change
| void register_configuration_key_changed_callback( | |
| void register_generic_configuration_key_changed_callback( |
There was a problem hiding this comment.
Please adjust other respective members accordingly.
include/ocpp/v16/charge_point.hpp
Outdated
| @@ -436,6 +436,12 @@ class ChargePoint { | |||
| void register_configuration_key_changed_callback(const CiString<50>& key, | |||
| const std::function<void(const KeyValue& key_value)>& callback); | |||
|
|
|||
| /// \brief registers a \p callback function that can be used to react on changed configuration key. This | |||
There was a problem hiding this comment.
Please adjust the method docs so to point out that this is a generic callback and that it will only be called in case no specific callback for the key is registered.
…changeconfiguration
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
Signed-off-by: Matthias Suess <[email protected]>
…is specified for the configuration_key_changed_callback Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Pietfried
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…if present