EV369: Message queue buffering #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt dropping non-transactional; tests - Extract MessageQueue config into dedicated struct - add parameters for limiting queue size and Queueing all message types - add check for message sizes and removal logic - restructure unit tests (common executuable) Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
hikinggrass
reviewed
Dec 5, 2023
lib/ocpp/v16/charge_point_impl.cpp
Outdated
| [this](json message) -> bool { return this->websocket->send(message.dump()); }, | ||
| MessageQueueConfig{this->configuration->getTransactionMessageAttempts(), | ||
| this->configuration->getTransactionMessageRetryInterval(), | ||
| this->configuration->getMessageQueueSizeThreshold().value_or(2E5), |
There was a problem hiding this comment.
2E5 should probably be defined in a constant
hikinggrass
reviewed
Dec 5, 2023
lib/ocpp/v201/charge_point.cpp
Outdated
| this->device_model->get_value<int>(ControllerComponentVariables::MessageAttempts), | ||
| this->device_model->get_value<int>(ControllerComponentVariables::MessageAttemptInterval), | ||
| this->device_model->get_optional_value<int>(ControllerComponentVariables::MessageQueueSizeThreshold) | ||
| .value_or(2E5), |
There was a problem hiding this comment.
reuse the (to be added) constant from ocpp 1.6 charge point
hikinggrass
reviewed
Dec 5, 2023
| @@ -0,0 +1,362 @@ | |||
| #include <gmock/gmock.h> | |||
There was a problem hiding this comment.
This is missing the license header
Suggested change
| #include <gmock/gmock.h> | |
| // SPDX-License-Identifier: Apache-2.0 | |
| // Copyright 2020 - 2023 Pionix GmbH and Contributors to EVerest | |
| #include <gmock/gmock.h> |
hikinggrass
reviewed
Dec 5, 2023
There was a problem hiding this comment.
This file is also missing its license header
// SPDX-License-Identifier: Apache-2.0
// Copyright 2020 - 2023 Pionix GmbH and Contributors to EVerest
hikinggrass
requested changes
Dec 5, 2023
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
hikinggrass
approved these changes
Dec 6, 2023
corneliusclaussen
deleted the
feature/fk-ev369-message-queue-buffering
branch
couryrr-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Dec 18, 2023
* MessageQueue: add config struct; add parameters for queueing; implement dropping non-transactional; tests - Extract MessageQueue config into dedicated struct - add parameters for limiting queue size and Queueing all message types - add check for message sizes and removal logic - restructure unit tests (common executuable) * add v201 config var for queue size threshold * add queue config parameters * remove temporary tests * add missing test resources * clang format * add missing constants; add missing headers Signed-off-by: Fabian Klemm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR addressing EV-369 to control the message buffer (addresses the "QueueAllMessages" configuration in OCPP 2.0.1.)
Implemented features:
Missing: This PR yet misses the capability to drop intermediate transaction events (in a follow-up PR)
Implementation details: