EV369b: drop update transactional messages if necessary #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt dropping non-transactional; tests - Extract MessageQueue config into dedicated struct - add parameters for limiting queue size and Queueing all message types - add check for message sizes and removal logic - restructure unit tests (common executuable) Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
hikinggrass
reviewed
Dec 5, 2023
hikinggrass
approved these changes
Dec 5, 2023
Co-authored-by: Kai Hermann <[email protected]> Signed-off-by: corneliusclaussen <[email protected]>
Base automatically changed from
feature/fk-ev369-message-queue-buffering
to
main
December 6, 2023 16:30
…messages Signed-off-by: Fabian Klemm <[email protected]> # Conflicts: # include/ocpp/common/message_queue.hpp # lib/ocpp/v16/charge_point_impl.cpp # lib/ocpp/v201/charge_point.cpp # tests/lib/ocpp/common/test_message_queue.cpp
klemmpnx
deleted the
feature/fk-ev369b-drop-update-transactional-messages
branch
couryrr-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Dec 18, 2023
* MessageQueue: add config struct; add parameters for queueing; implement dropping non-transactional; tests - Extract MessageQueue config into dedicated struct - add parameters for limiting queue size and Queueing all message types - add check for message sizes and removal logic - restructure unit tests (common executuable) Signed-off-by: Fabian Klemm <[email protected]> * add v201 config var for queue size threshold Signed-off-by: Fabian Klemm <[email protected]> * add queue config parameters Signed-off-by: Fabian Klemm <[email protected]> * remove temporary tests Signed-off-by: Fabian Klemm <[email protected]> * add missing test resources Signed-off-by: Fabian Klemm <[email protected]> * clang format Signed-off-by: Fabian Klemm <[email protected]> * EV269 Part II: drop transaction update events if necessary Signed-off-by: Fabian Klemm <[email protected]> * Update tests/lib/ocpp/common/test_message_queue.cpp Co-authored-by: Kai Hermann <[email protected]> Signed-off-by: corneliusclaussen <[email protected]> --------- Signed-off-by: Fabian Klemm <[email protected]> Signed-off-by: corneliusclaussen <[email protected]> Co-authored-by: corneliusclaussen <[email protected]> Co-authored-by: Kai Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part II of EV-369: drop transaction update messages if necessary: