B08 get custom report #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNSubramanya
force-pushed
the
B08-get-cutom-report
branch
from
81ee1de to
6181a6b
Compare
Signed-off-by: Soumya Subramanya <[email protected]>
SNSubramanya
force-pushed
the
B08-get-cutom-report
branch
from
55f8398 to
76d5631
Compare
marcemmers
requested changes
Jan 5, 2024
There was a problem hiding this comment.
Looking at the code I think get_report_data can be way simplified now since it only gets called from get base report which only ever provides a report_base argument. The component_variables and component_criteria arguments are always nullopt there.
This probably also means that you can replace component_criteria_match with your function since it is not used anymore and some more simplifications following from that.
config/v201/component_schemas/standardized/ChargingStation.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Soumya Subramanya <[email protected]> Modify component_criteria_match Signed-off-by: Soumya Subramanya <[email protected]> change mutability Signed-off-by: Soumya Subramanya <[email protected]> report only component matchign the criteria Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]> Push report values to vector Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]> Send component variables not having, active,available or enabled Signed-off-by: Soumya Subramanya <[email protected]> Add a not supported criteria variable Signed-off-by: Soumya Subramanya <[email protected]> Send all variables of a component criteria component Signed-off-by: Soumya Subramanya <[email protected]> Send component variables NOT having component criteria except Problem Signed-off-by: Soumya Subramanya <[email protected]> fix formatting Signed-off-by: Soumya Subramanya <[email protected]> B08>FR.02 Signed-off-by: Soumya Subramanya <[email protected]> Fix B08.FR.02 Signed-off-by: Soumya Subramanya <[email protected]> return values if no instance is present Signed-off-by: Soumya Subramanya <[email protected]> return values if no variables are present in the request Signed-off-by: Soumya Subramanya <[email protected]> Add a condition for evse missing Signed-off-by: Soumya Subramanya <[email protected]> remove bug Signed-off-by: Soumya Subramanya <[email protected]> divide component queries into with and without variable values Signed-off-by: Soumya Subramanya <[email protected]> divide component variable into has variable and not Signed-off-by: Soumya Subramanya <[email protected]> intermidiate commit Signed-off-by: Soumya Subramanya <[email protected]> works for no instance Signed-off-by: Soumya Subramanya <[email protected]> Add more conditions Signed-off-by: Soumya Subramanya <[email protected]> Add comment Signed-off-by: Soumya Subramanya <[email protected]> make notSupported criteria readwrite Signed-off-by: Soumya Subramanya <[email protected]> change incorrect evse_id for EVSE component Signed-off-by: Soumya Subramanya <[email protected]> Generate report for no evse id Signed-off-by: Soumya Subramanya <[email protected]> comment out B08.FR.19 Signed-off-by: Soumya Subramanya <[email protected]> revert to without B08.FR.19 Signed-off-by: Soumya Subramanya <[email protected]> [Ver3] rewrite Signed-off-by: Soumya Subramanya <[email protected]> Tests for with variables and with/without evseId Signed-off-by: Soumya Subramanya <[email protected]> fix fomatting Signed-off-by: Soumya Subramanya <[email protected]> Fix bug in B08.FR.02 Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]> Fix formatting Signed-off-by: Soumya Subramanya <[email protected]> formatting Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]> fix bug in matching Signed-off-by: Soumya Subramanya <[email protected]> fix formatting Signed-off-by: Soumya Subramanya <[email protected]> fix more formatting Signed-off-by: Soumya Subramanya <[email protected]> some more strange formatting Signed-off-by: Soumya Subramanya <[email protected]> PR changes Signed-off-by: Soumya Subramanya <[email protected]> fix formatting Signed-off-by: Soumya Subramanya <[email protected]>
SNSubramanya
force-pushed
the
B08-get-cutom-report
branch
from
4c7e0ad to
0a5a692
Compare
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
marcemmers
reviewed
Jan 10, 2024
|
|
||
| // if a criteria is not supported then send a not supported response. | ||
| auto sup_criteria = | ||
| this->device_model->get_optional_value<std::string>(ControllerComponentVariables::SupportedCriteria); |
There was a problem hiding this comment.
What happens if this optional value is not implemented? What do you want to happen?
There was a problem hiding this comment.
Hmm... that would void one of the requirements ...
marcemmers
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use case describes how the CSMS requests a Charging Station to send a report of all
Components and Variables limited to those that match ComponentCriteria and/or the list of
ComponentVariables. The result will be returned asynchronously in one or more
NotifyReportRequestmessages.