OCPP 2.0.1: Make message interval, retries, and timeout configurable at run-time #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me for OCPP 2.0.1 Signed-off-by: Valentin Dimov <[email protected]>
…ed correctly now Signed-off-by: Valentin Dimov <[email protected]>
valentin-dimov
force-pushed
the
feat/ocpp201-configurable-message-queue-parameters
branch
from
1daff51 to
badcc2f
Compare
Signed-off-by: Valentin Dimov <[email protected]>
…ter timeout Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
|
Something worth getting a second opinion on: When retrying a transaction-related message after a timeout or CallError, we will:
|
Signed-off-by: Valentin Dimov <[email protected]>
hikinggrass
approved these changes
Dec 8, 2023
That's something we should probably fix, reusing message id's doesn't seem the correct thing to do |
Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
|
Following some more discussion, it was decided that we will indeed re-generate new message IDs for retries, even if the retry was due to a time-out. |
hikinggrass
approved these changes
Dec 11, 2023
hikinggrass
deleted the
feat/ocpp201-configurable-message-queue-parameters
branch
couryrr-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Dec 18, 2023
…at run-time (EVerest#298) * feat: make message interval and message retries configurable at runtime for OCPP 2.0.1 * fix: intervals between resending messages are configurable and computed correctly now * fix: regenerate message IDs when retrying after CallError * Set default message timeout to 30 seconds. * fix: do not reuse message IDs, even in case of a timeout --------- Signed-off-by: Valentin Dimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.