Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional locking for next message to send #451

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Add additional locking for next message to send #451

merged 1 commit into from
Feb 7, 2024

Conversation

hikinggrass
Copy link
Contributor

No description provided.

@gregsq
Copy link

gregsq commented Feb 7, 2024

I'm going to patch this in and test.

@gregsq
Copy link

gregsq commented Feb 7, 2024

Tested with 500 upload overloads. Passes.

gregsq
gregsq approved these changes Feb 7, 2024
View reviewed changes
Copy link

@gregsq gregsq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with around 500 thundering herd requests. No signs of trouble using clang address sanitizer anymore.

@hikinggrass hikinggrass merged commit 06fcfa3 into main Feb 7, 2024
4 checks passed
@hikinggrass hikinggrass deleted the bugfix/locking branch February 7, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsq gregsq gregsq approved these changes

@Pietfried Pietfried Pietfried approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hikinggrass @gregsq @Pietfried