Special handling for value 0 for certain variables #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l, SampledDataTxEndedInterval Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Pietfried
requested review from
hikinggrass,
marcemmers and
maaikez
as code owners
hikinggrass
approved these changes
Feb 14, 2024
|
I don't really get why it wasn't already possible to configure 0 to these values? If it was failing on the minlimit shouldn't that be set to 0 then? Or do you want to only allow 0 and something higher than a certain value? |
Yes that's it, because 0 has a "special meaning" for these variables. When you want to use a minLimit > 0 but still want to allow the feature to be disabled with setting the variable to 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow value of 0 for AlignedDataInterval, SampledDataTxUpdatedInterval, SampledDataTxEndedInterval