Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AuthCacheDisablePostAuthorize and DisableRemoteAuthorization #476

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Feb 16, 2024

Describe your changes

The variables AuthCacheDisablePostAuthorize and DisableRemoteAuthorization have not yet been supported in the OCPP2.0.1 implementation.

The variables are not mentioned in any functional requirements, but the requirements are described in the definition:

  • 2.3.8. DisableRemoteAuthorization
  • 2.4.6. AuthCacheDisablePostAuthorize

This should cover (at least) the following OCTT test cases:

  • TC_E_52_CS
  • TC_C_57_CS

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Contributor

@marcemmers marcemmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another AuthorizeRequest in the local list part that is not allowed with DisableRemoteAuthorization set.

@Pietfried Pietfried merged commit 7e0ce54 into main Feb 19, 2024
4 checks passed
@Pietfried Pietfried deleted the feature/support-more-auth-variables branch February 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OCPP2.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants