Bugfix/494 libocpp verify csms cn wildcard #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
force-pushed
the
bugfix/494-libocpp-verify_csms_cn_wildcard
branch
from
e62da5b to
f9f753d
Compare
Pietfried
requested changes
Mar 6, 2024
AssemblyJohn
force-pushed
the
bugfix/494-libocpp-verify_csms_cn_wildcard
branch
from
f9f753d to
8d963f9
Compare
AssemblyJohn
force-pushed
the
bugfix/494-libocpp-verify_csms_cn_wildcard
branch
2 times, most recently
from
e4ec1e9 to
4dca13d
Compare
AssemblyJohn
requested review from
hikinggrass,
marcemmers and
maaikez
as code owners
AssemblyJohn
force-pushed
the
bugfix/494-libocpp-verify_csms_cn_wildcard
branch
2 times, most recently
from
59b911b to
5ac3957
Compare
Pietfried
previously requested changes
Mar 7, 2024
AssemblyJohn
force-pushed
the
bugfix/494-libocpp-verify_csms_cn_wildcard
branch
5 times, most recently
from
9564491 to
39c1688
Compare
|
All the comments were resolved. Note: codacity issue is a false-flag, the value IS used within the code in multiple places. |
barsnick
reviewed
Mar 11, 2024
barsnick
reviewed
Mar 11, 2024
hikinggrass
requested changes
Mar 12, 2024
Signed-off-by: AssemblyJohn <[email protected]>
resolves #494 Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Note: a workaround is used since libwebsocket overwrites the param usage when checking the server certificate Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/494-libocpp-verify_csms_cn_wildcard
branch
from
b76264e to
2802d1b
Compare
|
Note: when trying to use X509_VERIFY_PARAM_set1_host and SSL_CTX_set1_param(ctx, param); for the current context in the 'tls_init' function it seems that libwebsockets does not take into account the set parameter and any server certificate passes the check. Because of that, at the moment the server certificate's host is manually checked using the 'X509_check_host' routine. When we can see why libwebsockets does not take into account the automatic parameter check, a new fix should be introduced, removing the manual X509_check_host. |
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/494-libocpp-verify_csms_cn_wildcard
branch
from
2802d1b to
c0dfe0c
Compare
hikinggrass
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
resolves: #494
Checklist before requesting a review