Add unit tests for using components as keys in map #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-davis-afs
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
|
CC @shankari |
These tests help us understand how components are found in e.g. DeviceModelMap. Co-authored-by: Gianfranco Berardi <[email protected]> Signed-off-by: Christopher Davis <[email protected]>
christopher-davis-afs
force-pushed
the
cdavis/add-devicemodel-unit-tests
branch
from
2ccc8dd to
4e39cda
Compare
Pietfried
approved these changes
Mar 12, 2024
marcemmers
approved these changes
Mar 13, 2024
| .name = "Bar", | ||
| }; | ||
|
|
||
| EXPECT_EQ(components_to_ints.find(base_comp)->second, 1); |
There was a problem hiding this comment.
What would happen here if base_comp could not be found in the map?
There was a problem hiding this comment.
If the component isn't found and we access ->second without checking, it would be undefined behavior from what I understand. Here in the test I don't check because base_comp is in the map.
This was referenced May 2, 2024
|
Contributes to #361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
These tests help us understand how components are
found in e.g. DeviceModelMap.
Checklist before requesting a review