Added SWTCH to list of 2.0.1 CSMS #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert de Leeuw, PIONIX <[email protected]>
RobertDeLeeuw
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
marcemmers
reviewed
Mar 13, 2024
| @@ -148,6 +148,7 @@ Additionally, the implementation has been tested against those CSMS: | |||
| - [Monta](https://monta.com) | |||
| - [Open Charging Cloud (GraphDefined)](https://github.com/OpenChargingCloud/WWCP_OCPP) | |||
| - Switch EV | |||
| - SWTCH | |||
There was a problem hiding this comment.
Shouldn't we link to their webpage just like we did with the others? Maybe also update the Switch EV entry?
There was a problem hiding this comment.
We could. I only did it for the open source projects. No preference.
If you want I can add links to all of them.
There was a problem hiding this comment.
Ah didn't look further then my nose is long ;) Only saw up to monta in the diff. This is fine then.
marcemmers
approved these changes
Mar 13, 2024
| @@ -148,6 +148,7 @@ Additionally, the implementation has been tested against those CSMS: | |||
| - [Monta](https://monta.com) | |||
| - [Open Charging Cloud (GraphDefined)](https://github.com/OpenChargingCloud/WWCP_OCPP) | |||
| - Switch EV | |||
| - SWTCH | |||
There was a problem hiding this comment.
Ah didn't look further then my nose is long ;) Only saw up to monta in the diff. This is fine then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SWTCH CSMS to list of 2.0.1 tested systems
N/A
Checklist before requesting a review