Verify that EVSE exists. #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gberardi-pillar
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
|
@shankari Please review these changes. |
shankari
approved these changes
Mar 15, 2024
| @@ -27,12 +28,19 @@ enum class ProfileValidationResultEnum { | |||
| /// to calculate the composite schedules | |||
| class SmartChargingHandler { | |||
| private: | |||
| std::map<int32_t, std::unique_ptr<Evse>>& evses; | |||
There was a problem hiding this comment.
Here's another of these static code analysis checkers. Before community review, can you please clarify why this error is not important?
There was a problem hiding this comment.
This is one of the area where the checker that codacy uses seems to consistently have problems. The member is clearly used in the .cpp but a false positive is raised in the header anyway
gberardi-pillar
force-pushed
the
gberardi/v201-validate-evse
branch
from
3c06bc9 to
86f569e
Compare
|
@Pietfried @hikinggrass Are you able to review this PR? |
Pietfried
approved these changes
Mar 21, 2024
Signed-off-by: Gianfranco Berardi <[email protected]> Capitalization change. Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: Gianfranco Berardi <[email protected]> Capitalization suggestion. Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: Gianfranco Berardi <[email protected]> Capitalization suggestion. Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: Gianfranco Berardi <[email protected]>
gberardi-pillar
force-pushed
the
gberardi/v201-validate-evse
branch
from
2814d15 to
c215fd9
Compare
This was referenced May 2, 2024
|
Contributes to #361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes apply to K01.FR.28.
If the specified EVSE does not exist, then validation should reject it.