-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EVSE mockable and add mock #534
Conversation
CC: @shankari |
c2e193f
to
dd4b489
Compare
dd4b489
to
7c6483e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like after a rebase you need to also update
std::map<int32_t, std::unique_ptr<Evse>>& evses;
and
explicit SmartChargingHandler(std::map<int32_t, std::unique_ptr<Evse>>& evses);
.
and change the the EvseInterface
type
Except for me this looks good!
This commit changes EVSE into an interface that we can derive from to mock an EVSE. Signed-off-by: Christopher Davis <[email protected]>
Signed-off-by: Christopher Davis <[email protected]>
7c6483e
to
67014ce
Compare
Updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Contributes to #361 |
Describe your changes
This set of changes makes EVSE derived from an interface similar to what we did with ComponentStateManager,
and adds a mock to our set of mocks for v201.
Checklist before requesting a review