Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various custom data extensions #541

Merged
merged 12 commits into from
Apr 12, 2024
Merged

Conversation

hikinggrass
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Signed-off-by: Kai-Uwe Hermann <[email protected]>
It is now based on a json type with the only key that's required being "vendorId"

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass hikinggrass changed the title Various ustom data extensions Various custom data extensions Mar 26, 2024
customData needs to be initialized differently

Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass hikinggrass marked this pull request as ready for review April 8, 2024 08:06
Copy link
Contributor

@Pietfried Pietfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hikinggrass hikinggrass merged commit 8ba2086 into main Apr 12, 2024
4 checks passed
@hikinggrass hikinggrass deleted the feature/custom-data-extensions branch April 12, 2024 10:28
folkengine pushed a commit to US-JOET/libocpp that referenced this pull request Apr 15, 2024
* Add callback that's called when a TransactionEventResponse is received
* Update year in license header for OCPP 2.0.1 messages
* Add RequiredComponentVariable definition to 2.0.1 code generator
* Use "json" as type for DataTransfer data properties
* Fix implementation of CustomData
It is now based on a json type with the only key that's required being "vendorId"
* Add data_transfer_req function that accepts a DataTransferRequest parameter
* Fix device model test
customData needs to be initialized differently
* Fix notify report requests splitter test

---------

Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants