Made libwebsocket usage default #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
AssemblyJohn
force-pushed
the
enhancement/deprecate_websocketpp_default
branch
3 times, most recently
from
9e416fb to
e9ac589
Compare
…h a cmake option that is default OFF Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
enhancement/deprecate_websocketpp_default
branch
from
e9ac589 to
7e5ad55
Compare
Pietfried
previously requested changes
Apr 8, 2024
Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: John <[email protected]>
Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: John <[email protected]>
Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: John <[email protected]>
Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: John <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
hikinggrass
reviewed
Apr 8, 2024
AssemblyJohn
dismissed
Pietfried’s stale review
First batch of requested changes has been resolved.
Pietfried
reviewed
Apr 9, 2024
| if (connection_options.security_profile <= 1) { | ||
| this->websocket = std::make_unique<WebsocketPlain>(connection_options); | ||
| } else if (connection_options.security_profile >= 2) { | ||
| this->websocket = std::make_unique<WebsocketTLS>(connection_options, evse_security); | ||
| } | ||
| #else | ||
| this->websocket = std::make_unique<WebsocketTlsTPM>(connection_options, evse_security); |
There was a problem hiding this comment.
We should rename this class in another PR at some point..
marcemmers
approved these changes
Apr 9, 2024
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
approved these changes
Apr 9, 2024
folkengine
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Apr 15, 2024
* Made libwebsocket usage as default, and websocket++ usage enabled with a cmake option that is default OFF * Update README.md * Update dependencies.yaml * Update lib/CMakeLists.txt * Fixed import issue * Add missing find_package for libwebsockets in non-edm builds --------- Signed-off-by: AssemblyJohn <[email protected]> Signed-off-by: John <[email protected]> Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Websocket++ usage has been deprecated and due to future heavy interface refactoring it has been removed from the default compilation. Libwebsocket has been made the default websocket library that is used.
Issue ticket number and link
Checklist before requesting a review