OCPP1.6: Fix handling of SetChargingProfile(TxProfile) #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested review from
hikinggrass,
marcemmers and
maaikez
as code owners
…ve transaction. This was fixed with this change. Added further test cases * Fixed bug that Recurring profiles were accepted without validating profile purpose Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
bugfix/validate-tx-profile
branch
from
13daa52 to
a5b29f1
Compare
hikinggrass
approved these changes
May 13, 2024
christopher-davis-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
May 30, 2024
…ve transaction. This was fixed with this change. Added further test cases (EVerest#616) * Fixed bug that Recurring profiles were accepted without validating profile purpose Signed-off-by: pietfried <[email protected]>
drmrd
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Jun 4, 2024
…ve transaction. This was fixed with this change. Added further test cases (EVerest#616) * Fixed bug that Recurring profiles were accepted without validating profile purpose Signed-off-by: pietfried <[email protected]> Signed-off-by: Daniel Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
TxProfiles without a
transactionIdare still accepted in case:A transaction is active for this connector
OR
TxProfile is part of
RemoteStartTransaction.req(ignore_no_transactionis set to true)Issue ticket number and link
Related discussion: #299
Checklist before requesting a review