Rework of OCPP SmartCharging #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
force-pushed
the
pg-smart-charging
branch
from
33b9019 to
fc0a8cf
Compare
a-w50
reviewed
Dec 13, 2022
include/ocpp1_6/smart_charging.hpp
Outdated
Comment on lines
16
to
21
| static const int LOW_VOLTAGE = 230; | ||
| static const int DEFAULT_AND_MAX_NUMBER_PHASES = 3; | ||
| static const int HOURS_PER_DAY = 24; | ||
| static const int SECONDS_PER_HOUR = 3600; | ||
| static const int SECONDS_PER_DAY = 86400; | ||
| static const int DAYS_PER_WEEK = 7; |
There was a problem hiding this comment.
Using static here is not a good idea in general, because it will create an instance in every compilation unit (cpp file), that is including this header file.
Pietfried
force-pushed
the
pg-smart-charging
branch
7 times, most recently
from
10d68eb to
5e24668
Compare
- added class SmartChargingHandler - supporting all ChargingProfilePurpose and ChargingProfileKind - storing charging profiles persistently - added table CHARGING_PROFILES to database - added database tests for charging profiles Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
pg-smart-charging
branch
from
5e24668 to
f0479f0
Compare
hikinggrass
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pietfried [email protected]