Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Subsequent validation of existing profiles for OCPP2.0.1 #837

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Oct 16, 2024

Describe your changes

  • Added test case to check if existing profiles can properly validated
  • Fixed validation of TxProfile(s) by checking profile id so profiles are the same profiles do not conflict Fixed check for overlapping validity period.
  • The chargingProfileKind was used for checking validity period overlaps between profiles although K01.FR.06 requires:

The CSMS SHALL NOT send a ChargingProfile with a
stackLevel - chargingProfilePurpose - evseId combination
that already exists in another ChargingProfile (with
different id) on the Charging Station and has an
overlapping validity period.

The combination that was checked before this change was:
stackLevel - chargingProfileKind- evseId

These changes allow OCTT TC_K_41_CS to PASS.

Issue ticket number and link

#819

Checklist before requesting a review

Fixed validation of TxProfile(s) by checking profile id so profiles are the same profiles do not conflict
Fixed check for overlapping validity period. The chargingProfileKind was used although K01.FR.06 requires chargingProfilePurpose instead

Signed-off-by: Piet Gömpel <[email protected]>
@Pietfried Pietfried merged commit 83172ee into main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect profile selection for GetCompositeSchedule.req handler
2 participants