Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed websocket++ as a dependency #846

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

AssemblyJohn
Copy link
Contributor

@AssemblyJohn AssemblyJohn commented Oct 24, 2024

Describe your changes

Removed websocket++ from the cmake files and source files.

Issue ticket number and link

Closes: #387 (comment)

Checklist before requesting a review

@AssemblyJohn
Copy link
Contributor Author

AssemblyJohn commented Oct 24, 2024

I'd require some ideas on the new websocket class implementation name (from file 'websocket_libwebsockets.cpp' and name 'WebsocketTlsTPM'), since we already have a file called 'websocket.cpp' & a class called 'Websocket'.

@Pietfried
Copy link
Contributor

I'd require some ideas on the new websocket class implementation name (from file 'websocket_libwebsockets.cpp' and name 'WebsocketTlsTPM'), since we already have a file called 'websocket.cpp' & a class called 'Websocket'.

The filename websocket_libwebsockets is fine. The class name would then be WebsocketLibwebsockets.

@marcemmers
Copy link
Contributor

marcemmers commented Oct 28, 2024

There are still some websocketpp header files present that should be removed. Both in the include/common/websocket and in 3rd_party.

Also, can't we just get rid of the Websocket class itself since it is just a wrapper over WebocketLibwebsockets now that only adds a few log lines. Then we no longer have this question of naming either. Just name WebocketLibwebsockets Websocket and we are done.

@Pietfried Pietfried self-assigned this Oct 29, 2024
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn force-pushed the deprecation/websocketpp branch from eb5a21b to b326513 Compare October 29, 2024 14:07
@AssemblyJohn
Copy link
Contributor Author

AssemblyJohn commented Oct 29, 2024

There are still some websocketpp header files present that should be removed. Both in the include/common/websocket and in 3rd_party.

Also, can't we just get rid of the Websocket class itself since it is just a wrapper over WebocketLibwebsockets now that only adds a few log lines. Then we no longer have this question of naming either. Just name WebocketLibwebsockets Websocket and we are done.

Removed the unused headers, thanks for pointing it out! The 3rd_party is required for some URI validation. I don't exclude in the future to write our own code to take care of that. As for Websocket/WebsocketLibwebsockets, it's better to remain like this since we might add an alternate library instead of libwebsockets. Or at least that is how it was designed in the first place.

@hikinggrass hikinggrass merged commit 6a00102 into main Oct 30, 2024
4 checks passed
@hikinggrass hikinggrass deleted the deprecation/websocketpp branch October 30, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace WebSocket++ with libwebsockets
4 participants