-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed websocket++ as a dependency #846
Conversation
I'd require some ideas on the new websocket class implementation name (from file 'websocket_libwebsockets.cpp' and name 'WebsocketTlsTPM'), since we already have a file called 'websocket.cpp' & a class called 'Websocket'. |
The filename |
fd8ae26
to
565e651
Compare
There are still some websocketpp header files present that should be removed. Both in the Also, can't we just get rid of the |
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
eb5a21b
to
b326513
Compare
Removed the unused headers, thanks for pointing it out! The 3rd_party is required for some URI validation. I don't exclude in the future to write our own code to take care of that. As for Websocket/WebsocketLibwebsockets, it's better to remain like this since we might add an alternate library instead of libwebsockets. Or at least that is how it was designed in the first place. |
Describe your changes
Removed websocket++ from the cmake files and source files.
Issue ticket number and link
Closes: #387 (comment)
Checklist before requesting a review