Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces and mocks for connectivity manager and ocsp updater. #918

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

maaikez
Copy link
Contributor

@maaikez maaikez commented Dec 16, 2024

Describe your changes

Add interfaces and mocks for the connectivity manager and ocsp updater.

This is needed to be able to create a function block for security.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • [n/a] I have made corresponding changes to the documentation
  • [n/a] If OCPP 2.0.1: I have updated the OCPP 2.0.1 status document
  • I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Contributor

@Pietfried Pietfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You can drop the virtual keyword in the derived classes ConnectivityManager and OcspUpdater since its inherited from the interface. This also more in line with the existing interfaces we have

Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
@maaikez maaikez merged commit 3869f69 into main Dec 17, 2024
8 checks passed
@maaikez maaikez deleted the feature/create_mocks_ocspupdater_connectivitymanager branch December 17, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants