Refactoring of composite schedule calculation #943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The main purpose of this change was to fix an issue discovered during testing with OCTT. The scenario:
Along the way I fixed another issue: Conversion between power and current was done to early resulting in issues especially when the number of phases was non default.
The bulk of the functionality to calculate the composite profile in
profile.cpp
has been split into several functions to make it easier to understand how the code is composed.There are also still some gaps left in this code. We currently have default limits that are global, so the same for the whole charging station and EVSEs. It could be the case that different EVSEs have different default limits or that the CS has a higher limit (since it needs to support multiple EVSEs. This is something that will need to be added in a later PR.
Issue ticket number and link
Checklist before requesting a review