Refactor/libfsm removal #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
approved these changes
May 2, 2023
a-w50
force-pushed
the
refactor/libfsm_removal
branch
2 times, most recently
from
3a69c8f to
88f8783
Compare
- FSM has been replaced by simple lookup map - simple refactor of parts that depend on ChargePointFSM classe - moved number_of_connectors from ChargePointStates ctor and moved check of configured connectors and connectors in db to chargepoint Signed-off-by: aw <[email protected]> Co-authored-by: pietfried <[email protected]>
a-w50
force-pushed
the
refactor/libfsm_removal
branch
from
88f8783 to
1a59f62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if tests work out and approved, rebase and squash needs still to be done