Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where retry of certificate signing is too fast #970

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

maaikez
Copy link
Contributor

@maaikez maaikez commented Jan 30, 2025

should be at least 250 seconds, but was 250 milliseconds.

Describe your changes

#969

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • [n/a] I have made corresponding changes to the documentation
  • [n/a] If OCPP 2.0.1: I have updated the OCPP 2.0.1 status document
  • I read the contribution documentation and made sure that my changes meet its requirements

@maaikez maaikez linked an issue Jan 30, 2025 that may be closed by this pull request
…onds but was 250 milliseconds.

Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
@maaikez maaikez force-pushed the bug/signcertificaterequest-almost-immediately-resent branch from 485a6aa to d3502d1 Compare February 3, 2025 15:58
@maaikez maaikez merged commit 7f3687d into main Feb 3, 2025
8 checks passed
@maaikez maaikez deleted the bug/signcertificaterequest-almost-immediately-resent branch February 3, 2025 16:16
hikinggrass pushed a commit that referenced this pull request Feb 17, 2025
* Fix bug where retry of certificate signing should be at least 250 seconds but was 250 milliseconds.
* Set CertSigningWaitMinimum to a value of 30.

Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
maaikez added a commit that referenced this pull request Feb 17, 2025
* Fix bug where retry of certificate signing should be at least 250 seconds but was 250 milliseconds.
* Set CertSigningWaitMinimum to a value of 30.

Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignCertificateRequest almost immediately resent
3 participants