Fix bug where security event notification was sent while bootnotification was still pending. #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting a flag when retrieving it from the database to wait sending the message until the bootnotification is accepted, fixes it. Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
Pietfried
approved these changes
Feb 12, 2025
maaikez
deleted the
bug/securityeventnotificationreq-are-sent-before-csms-accepted-bootnotification
branch
hikinggrass
pushed a commit
that referenced
this pull request
Feb 17, 2025
…ation was still pending. #984 Bug was caused by security event messages stored in the database. Setting a flag when retrieving it from the database to wait sending the message until the bootnotification is accepted, fixes it. Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
maaikez
added a commit
that referenced
this pull request
Feb 17, 2025
…ation was still pending. #984 Bug was caused by security event messages stored in the database. Setting a flag when retrieving it from the database to wait sending the message until the bootnotification is accepted, fixes it. Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Bug was caused by security event messages stored in the database. Setting a flag when retrieving it from the database to wait sending the message until the bootnotification is accepted, fixes it.
Issue ticket number and link
#983
Checklist before requesting a review