Upgrade WebpackEncore version #6590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @javiereguiluz, FYI this has been introduced in https://github.com/symfony/webpack-encore/releases/tag/v4.0.0 for many reasons, adding those dependencies by yourself is perfect :) |
javiereguiluz
force-pushed
the
upgrade_webpack_encore
branch
from
e263a5d to
554dfa6
Compare
|
@javiereguiluz I am a bit late but you can also take a look at the webpack recipes and compare with previous one:
It looks like some dependencies such as |
|
Nothing to do here with But as you can see, it is not present in EasyAdminBundle: |
javiereguiluz
added a commit
that referenced
this pull request
Dec 7, 2024
This PR was squashed before being merged into the 4.x branch. Discussion ---------- Update the Webpack Encore configuration As commented by `@Seb33300` in #6590 (comment) we should have checked the latest recipe for Webpack Encore (https://github.com/symfony/recipes/blob/main/symfony/webpack-encore-bundle/2.0/package.json) when upgrading its configuration. So, I just did that and added the missing packages. #SymfonyHackday Commits ------- d901a91 Update the Webpack Encore configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we still used the ancient 2.x version of WebpackEncore. Let's upgrade to the most recent version.
Upgrading just WebpackEncore showed a lot of "unmeet peer dependency" errors. That's why I added
@babel/core,webpack, etc. todevDependencies. Let me ping @Kocal to see if he can quickly validate this or suggest a better alternative to fix those errors. Thanks a lot!