Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename assets to RPG2k3 English RTP, add missing sounds #27

Merged
merged 6 commits into from
Mar 4, 2022

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Mar 2, 2022

@Ghabry Ghabry requested a review from jetrotal March 2, 2022 14:01
@jetrotal
Copy link
Contributor

jetrotal commented Mar 2, 2022

We may also need to review the attribution part of the authors file, to include the proper credits to it

https://community.easyrpg.org/t/basis-png-by-jikmok/146

@Ghabry
Copy link
Member Author

Ghabry commented Mar 2, 2022

Yeah the attribution is kinda messy and in some cases so detailed that it does not fit into our table.

There could be also a "FILE_NAME.license" file next to each asset. The Editor could process this file and display copyright information in the asset browser.

Was also thinking of embedding Exif chunks (supported since 2017 for PNG) into the images for attribution. Sure they are often lost due to applications not writing them but better than nothing ^^

@jetrotal
Copy link
Contributor

jetrotal commented Mar 2, 2022

https://github.com/MedicineStorm/RTP/blob/master/AUTHORS.md

Here, Medicine Storm already researched and organized some of the OGA links

@Ghabry Ghabry merged commit c862745 into EasyRPG:master Mar 4, 2022
@Ghabry Ghabry deleted the update branch March 4, 2022 22:43
Title/Title1.png | (c) 2010 Francisco de la Peña [CC0] | https://easyrpg.org
Title/Title2.png | (c) 2010 Francisco de la Peña [CC0] | https://easyrpg.org
Title/Title3.png | (c) 2010 Francisco de la Peña [CC0] | https://easyrpg.org
Title/Title4.png | (c) 2010 Francisco de la Peña [CC0] | https://easyrpg.org

[CC0]: https://creativecommons.org/publicdomain/zero/1.0/deed.de
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.en would have been better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic redirects :/
Good catch fixing this the next time I make a PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants