Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONL-5955: Update to postcss8 #884

Merged
merged 13 commits into from
Aug 26, 2021
Merged

ONL-5955: Update to postcss8 #884

merged 13 commits into from
Aug 26, 2021

Conversation

mcibique
Copy link
Contributor

Postcss 8 introduced lots of breaking changes and not a single plugin is compatible so we had to wait until everybody upgrades. Unfortunately, postcss-preset-env wasn't unable to do that even today because it contains 30+ other postcss plugins. Because we don't use any syntax from postcss-preset-env, I decided to remove the plugin from chameleon and EBO. So did other projects.

Updated Tailwind to version 2 and updated config. The changelog is huge but it affects us only in few places:

  1. filters have been added to TW, so the tailwind-filters plugin is no longer needed. The filters have been used only in one place in chameleon, 0 in EBO so it was safe to migrate.
  2. TW2 has some issues when used directly inside of a postcss-mixin. There is a workaround mentioned in this issue.
  3. Tailwind's transformations have been reworked and they cannot be used in the animations anymore. It broke spin animation for loading icons.

@mcibique mcibique requested a review from a team August 23, 2021 12:25
@mcibique mcibique self-assigned this Aug 23, 2021
@vercel
Copy link

vercel bot commented Aug 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ebury/chameleon/5JgE5K1m6h1Kx2CC8R8wh2QavUqg
✅ Preview: https://chameleon-git-onl-5955-postcss8-ebury.vercel.app

@mcibique mcibique changed the title ONL-5955: Update to postcss8 [WIP] ONL-5955: Update to postcss8 Aug 23, 2021
@mcibique mcibique removed the request for review from a team August 23, 2021 12:27
@mcibique mcibique requested a review from a team August 23, 2021 15:38
@mcibique mcibique changed the title [WIP] ONL-5955: Update to postcss8 ONL-5955: Update to postcss8 Aug 23, 2021
@mcibique mcibique merged commit 80ba71d into master Aug 26, 2021
@mcibique mcibique deleted the ONL-5955-postcss8 branch August 26, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants