ReadData updates

[claireh93]

A few simple changes to read functions.

Closes #85

[claireh93]

@richardreeve do we think we are ready to release v0.1.3 after this goes through? I need it in order for the Pluto notebooks to work

[coveralls]

Pull Request Test Coverage Report for Build 2172848642

• 10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.05%) to 65.4%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/ClimatePref/ReadData.jl	5	6	83.33%
src/Dist.jl	5	6	83.33%

Files with Coverage Reduction	New Missed Lines	%
src/Dist.jl	1	89.19%

Totals
Change from base Build 1196793281:	0.05%
Covered Lines:	1686
Relevant Lines:	2578

---

💛 - Coveralls

[codecov]

Codecov Report

Merging #83 (318fd6e) into main (07408b6) will increase coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   73.20%   73.25%   +0.05%     
==========================================
  Files          26       26              
  Lines        2000     2004       +4     
==========================================
+ Hits         1464     1468       +4     
  Misses        536      536              

Impacted Files	Coverage Δ
src/Dist.jl	89.18% <83.33%> (+0.61%)	⬆️
src/units.jl	100.00% <0.00%> (ø)
src/EcoSISTEM.jl	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07408b6...318fd6e. Read the comment docs.

[richardreeve]

@claireh93 - I'm happy for this to merge, and for you to release 0.1.3.

However, maybe first I've also discovered something really cool to fix our problems with examples not working with the current dev EcoSISTEM git version of the code on other people's machines - the problem is either you have no manifest in the examples folder and it installs the latest release, or you have one and the path is for your computer so doesn't work for others. Anyway, the solution is:

pkg> activate examples/Biodiversity

(Biodiversity) pkg> add .

This doesn't change the Project.toml, but creates a Manifest.toml with the relative path in it:

repo-url = "../.."

And that works on anyone's machine! Cool, eh? Anyway, I thought you might want to add in the manifests into examples/Biodiversity and anywhere else, so everything worked with relative paths? Just a thought, and we will have to remember to update them, but I do find it v annoying that we couldn't reliably run examples in live repos rather than releases... either way, you could just release 0.1.3 now. I'm not that fussed. Just remember to update the NEWS.md as well as the Project.toml.

[claireh93]

@richardreeve that's cool! I'd like to add that in before we release 0.1.3 then

[richardreeve]

Incidentally, you get slightly different Manifests depending on whether you type add . or dev . and I'm not really sure which one is best - they both seem to work?

[richardreeve]

I think maybe dev . is better because it doesn't include this:

git-tree-sha1 = "29c67a69573fa38c8c4e415bcbf6efef3e17736e"

which may break when you do additional commits to the repo.

[claireh93]

@richardreeve could you check these work on your machine please?

[richardreeve]

Found a couple of missing dependencies in the examples folder... it would be good to automatically run at least examples/exampleModels.jl in the CI if we can work out how to do it?

[richardreeve]

Okay @claireh93, that works for me now, but you may want to check it again!

[claireh93]

Found a couple of missing dependencies in the examples folder... it would be good to automatically run at least examples/exampleModels.jl in the CI if we can work out how to do it?

Yes I think that sounds like a good plan, I'll have a go at that this afternoon - then at least we know the loading of the examples works for people!

[claireh93]

@richardreeve I have added a test to the examples folder so that we know it can build (exampleModels.jl takes too long to run). However, it seems like worldclim is down, so tests are currently failing

[richardreeve]

Okay @claireh93 - the site is still down, so let's just wait until it's up to check everything is working...

[richardreeve]

Just fiddling with this because I need to start looking at PRs again and I just thought I'd start with some tidying. Feel free to ignore if you don't like it!