Add unit test cases to validate if instanceType empty can be saved in…

… OdsInstance
Ed-Fi-Alliance-OSS · Aug 6, 2024 · 1d09303 · 1d09303
1 parent ebace8d
commit 1d09303
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 0 deletions.
diff --git a/Application/EdFi.Ods.AdminApi.DBTests/Database/CommandTests/AddOdsInstanceCommandTests.cs b/Application/EdFi.Ods.AdminApi.DBTests/Database/CommandTests/AddOdsInstanceCommandTests.cs
@@ -43,4 +43,31 @@ public void ShouldAddOdsInstance()
             profile.ConnectionString.ShouldBe(odsInstanceConnectionString);
         });
     }
+
+    [Test]
+    public void ShouldAddOdsInstanceWithEmptyInstanceType()
+    {
+        var odsInstanceName = $"Test-OdsInstance{Guid.NewGuid()}";
+        var odsInstanceConnectionString = "ConnectionString";
+        var newOdsInstance = new Mock<IAddOdsInstanceModel>();
+        newOdsInstance.Setup(x => x.Name).Returns(odsInstanceName);
+        newOdsInstance.Setup(x => x.ConnectionString).Returns(odsInstanceConnectionString);
+
+
+        var id = 0;
+        Transaction(usersContext =>
+        {
+            var command = new AddOdsInstanceCommand(usersContext);
+            id = command.Execute(newOdsInstance.Object).OdsInstanceId;
+            id.ShouldBeGreaterThan(0);
+        });
+
+        Transaction(usersContext =>
+        {
+            var profile = usersContext.OdsInstances.Single(v => v.OdsInstanceId == id);
+            profile.Name.ShouldBe(odsInstanceName);
+            profile.InstanceType.ShouldBeEmpty();
+            profile.ConnectionString.ShouldBe(odsInstanceConnectionString);
+        });
+    }
 }
diff --git a/Application/EdFi.Ods.AdminApi.DBTests/Database/CommandTests/EditOdsInstanceCommandTests.cs b/Application/EdFi.Ods.AdminApi.DBTests/Database/CommandTests/EditOdsInstanceCommandTests.cs
@@ -57,5 +57,30 @@ public void ShouldEditOdsInstance()
             changedOdsInstance.InstanceType.ShouldBe(instanceType);
             changedOdsInstance.ConnectionString.ShouldBe(connectionString);
         });
+    }
+
+    [Test]
+    public void ShouldEditOdsInstanceWithEmptyInstanceType()
+    {
+        var name = "new odsinstance name";
+        var connectionString = "new odsinstance connection string";
+        var newOdsInstanceData = new Mock<IEditOdsInstanceModel>();
+        newOdsInstanceData.Setup(v => v.Id).Returns(_odsInstanceId);
+        newOdsInstanceData.Setup(v => v.Name).Returns(name);
+        newOdsInstanceData.Setup(v => v.ConnectionString).Returns(connectionString);
+
+        Transaction(usersContext =>
+        {
+            var editOdsInstanceCommand = new EditOdsInstanceCommand(usersContext);
+            editOdsInstanceCommand.Execute(newOdsInstanceData.Object);
+        });
+
+        Transaction(usersContext =>
+        {
+            var changedOdsInstance = usersContext.OdsInstances.Single(v => v.OdsInstanceId == _odsInstanceId);
+            changedOdsInstance.Name.ShouldBe(name);
+            changedOdsInstance.InstanceType.ShouldBeEmpty();
+            changedOdsInstance.ConnectionString.ShouldBe(connectionString);
+        });
     }
 }