Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSS-3] Initial documentation files #1

Merged
merged 2 commits into from
May 4, 2020
Merged

[OSS-3] Initial documentation files #1

merged 2 commits into from
May 4, 2020

Conversation

DavidJGapCR
Copy link
Contributor

No description provided.

@DavidJGapCR DavidJGapCR requested review from lalrg and jleiva-gap May 4, 2020 16:44
lalrg
lalrg suggested changes May 4, 2020
View reviewed changes
Copy link

@lalrg lalrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few things that you should update. Once that is ready, I can review it again if you need.

CONTRIBUTORS.md Outdated

Ed-Fi Alliance\
Mr. Ed <[email protected]>\
[Gumby](https://github.com/this-is-a-fake-profile)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yoy can remove from line 13 to 15 since this contributor is just an example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

CONTRIBUTORS.md Outdated
since many employees of one corporation may be contributing. To see the full
list of contributors, see the revision history in source control or the [GitHub
contributors
graph](https://github.com/Ed-Fi-Alliance-OSS/Ed-Fi-Standard/graphs/contributors).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this link to make it redirect to the current repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

NOTICES.md
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file needs some format, you can look at this review from Stephen for having a reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

lalrg
lalrg approved these changes May 4, 2020
View reviewed changes
Copy link

@lalrg lalrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good

@jleiva-gap jleiva-gap merged commit 1cefcf0 into development May 4, 2020
@jleiva-gap jleiva-gap deleted the OSS-3 branch May 4, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalrg lalrg lalrg approved these changes

@jleiva-gap jleiva-gap jleiva-gap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidJGapCR @lalrg @jleiva-gap