[ODS-6580] Replace Change Queries' AFTER UPDATE trigger with NHibernate interceptor #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelmarquezh
requested changes
Feb 6, 2025
There was a problem hiding this comment.
I didn't find Postman tests that cover the next scenarios:
- Changes to root and non-root entities (independently) still result in ChangeVersion value updates.
- Changes to a resource’s primary key values (using one of those that allows it), updates the ChangeVersion and LastModifiedDate of dependent resources, including coverage of resources impacted directly (foreign key is to root entity) and indirectly (foreign key is to a child entity).
| if (sql.StartsWithCaseInsensitive(updateText)) | ||
| { | ||
| // Add the ChangeVersion column update clause immediately after the SET keyword | ||
| SqlString updatedSql = sql.Insert(updateText.Length, _changeVersionSetClause); |
There was a problem hiding this comment.
This fails if I disable the ChangeQueries feature by following these instructions. The error message is: Invalid column name 'ChangeVersion'.
Consider checking if the feature is enabled.
…or SQL Server and PostgreSQL for Ed-Fi Standard 4.0.0 and 5.2.0. Implemented support for SQL Server UPDATE statements to include NEXT VALUE FOR to assign ChangeVersion column value in lieu of server-side AFTER UPDATE trigger. Modified test after expansion of values required for NHibernate interceptor configuration. Post rebase fixes. Namespace cleanup. Added script to drop update triggers for SQL Server Standard v4.0.0 and v5.2.0. Update triggers for SQL Server Standard v4.0.0 and v5.2.0 to not create a new change version for the tracked key change entry. Add PostgreSQL migration scripts for v5.2 and v4.0 standards to remove update triggers for updating the changeversion. Updated scripts for SQL Server and PostgreSQL for v4.0 and v5.2 to include a ChangeVersion sequence value update in the indirect cascade update triggers. Modified interceptor logic to process queries for PostgreSQL as well as SQL Server. Removed the CREATE TRIGGER statement from the change script since the trigger will already exist. Update SQL Server change script for Homograph extension to use 'CREATE OR ALTER TRIGGER' since triggers will already exist. Updated SQL interception behavior to use dialect (for SQL Server and PostgreSQL support). Updated PostgreSQL migration scripts to remove the UpdateChangeVersion function using CASCADE keyword to eliminate all dependent triggers. Fixed issue encountered when running NHibernate requests outside of regular APi request context. Fixed ChangeVersion handling for derived resources. Added feature check to SQL interception to prevent use of ChangeVersion when the feature is turned off. SQL Server migration scripts accounting for cascading keys and volatile keys. PostgreSQL Server migration scripts for Ed-Fi Standard 4.0.0 and 5.2.0 accounting for cascading keys and volatile keys. Renamed PostgreSQL 5.2.0 file to match name of 4.0.0. file. SQL Server migration scripts for Ed-Fi Standard 4.0.0 and 5.2.0 accounting for cascading keys and volatile keys.
… handle cascading key updates for SQL Server.
…nd Change Queries.
….2 and v4.0 for test data, and removing unreliable test expectation.
…astModifiedDate due to cascading key trigger as source of invocation.
…iscrepancies between v4.0 and v5.2 sample data sets and model differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the 3 pull requests that are part of ODS-6580: